feat: add an optional modtime section to the filepicker#807
Open
loicalbertin wants to merge 3 commits intocharmbracelet:v2-expfrom
Open
feat: add an optional modtime section to the filepicker#807loicalbertin wants to merge 3 commits intocharmbracelet:v2-expfrom
loicalbertin wants to merge 3 commits intocharmbracelet:v2-expfrom
Conversation
To make the filepicker looks like a bit more `ls -l`, allow to optionally display file modification time. For backward compatibility this is disabled by default. The default modification time layout format is similar to the one in `ls -l`. This is configurable using standard time.Format() supported layouts. Fixes Add modification time to the filepicker charmbracelet#780
loicalbertin
commented
Jun 30, 2025
meowgorithm
reviewed
Aug 13, 2025
| ) | ||
|
|
||
| // DefaultModTimeLayout is the default layout used to format modification time for a given file. | ||
| const DefaultModTimeLayout = "Jan _2 15:04" |
Member
There was a problem hiding this comment.
Any particular reason to export this?
Author
There was a problem hiding this comment.
No particular reason expect to have it easily accessible in the documentation.
We could make it private if you prefer.
Member
There was a problem hiding this comment.
Ah, well that's good enough reason to keep it public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add an optional modtime section to the filepicker. This makes the filepicker looks like a bit more
ls -l.For backward compatibility this is disabled by default.
The default modification time layout format is similar to the one in
ls -l. This is configurable using standard time.Format() supported layouts.Related issue/discussion:
Issue: #805 (v2) Add modification time to the filepicker
Discussion: #792
Checklist before requesting a review
CONTRIBUTING.mdIf this is a feature